Extract common code to AbstractEclipseBuildMojo so it can be reused #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
Currently EclipseBuildMojo performs the boilerplate to perform an eclipse like build inside tycho build, but this can be useful for other scenarios as well. This now extracts the common code into an AbstractEclipseBuildMojo so it can be reused.
laeubi
force-pushed
the
abstraction_of_eclipse_build
branch
from
75c30e8 to
fa7ca73
Compare
Test Results 606 files ±0 606 suites ±0 4h 10m 6s ⏱️ - 33m 35s For more details on these failures, see this check. Results for commit fa7ca73. ± Comparison against base commit d0109ca. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently EclipseBuildMojo performs the boilerplate to perform an eclipse like build inside tycho build, but this can be useful for other scenarios as well.
This now extracts the common code into an AbstractEclipseBuildMojo so it can be reused.